-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Firebase authentication provider is implemented #3174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// Helper functions for accessing the qq Graph API. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bad comment. |
||
var Parse = require('parse/node').Parse; | ||
var admin = require("firebase-admin"); | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove empty line |
||
var firebaseServiceAccount = process.env.FIREBASE_SERVICE_ACCOUNT; | ||
if (firebaseServiceAccount != null) { | ||
admin.initializeApp({ | ||
credential: admin.credential.cert(require(firebaseServiceAccount)) | ||
}); | ||
} | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove empty line |
||
// Returns a promise that fulfills iff this user id is valid. | ||
function validateAuthData(authData) { | ||
if (firebaseServiceAccount == null || firebaseServiceAccount == "") { | ||
throw new Parse.Error(Parse.Error.FILE_READ_ERROR, "Firebase service account file not exists"); | ||
} | ||
|
||
return admin.auth().verifyIdToken(authData.access_token) | ||
.then(function (decodedToken) { | ||
if (decodedToken == null || decodedToken.uid == null || decodedToken.uid == "") { | ||
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, "Firebase user not found"); | ||
} | ||
return; | ||
}).catch(function (error) { | ||
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, error.message); | ||
}); | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove empty line |
||
} | ||
|
||
// Returns a promise that fulfills if this app id is valid. | ||
function validateAppId() { | ||
return Promise.resolve(); | ||
} | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove empty line |
||
module.exports = { | ||
validateAppId, | ||
validateAuthData | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,8 @@ let vkontakte = require("./vkontakte"); | |
let qq = require("./qq"); | ||
let wechat = require("./wechat"); | ||
let weibo = require("./weibo"); | ||
let firebase = require("./firebase"); | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove empty line |
||
|
||
let anonymous = { | ||
validateAuthData: () => { | ||
|
@@ -39,7 +41,8 @@ let providers = { | |
vkontakte, | ||
qq, | ||
wechat, | ||
weibo, | ||
firebase | ||
} | ||
|
||
module.exports = function(oauthOptions = {}, enableAnonymousUsers = true) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure we want to depend on that module for every single user.
You can probably provide that module externally.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i'll try to provide externally. thanks for your feedback.