Skip to content

Allow queries with String array for pointers containedIn #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2017

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Sep 19, 2017

This provides a lighter way to run a contained in with a pointer column, without serializing all the garbage for className/type etc.., lighter requests, better API!

Will most probably fail on PG (was already supported)

@flovilmart flovilmart changed the title Investigate pointer contained in Allow queuing with String array for pointers containedIn Sep 19, 2017
@codecov
Copy link

codecov bot commented Sep 19, 2017

Codecov Report

Merging #4188 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4188      +/-   ##
==========================================
+ Coverage   92.21%   92.21%   +<.01%     
==========================================
  Files         116      116              
  Lines        8089     8093       +4     
==========================================
+ Hits         7459     7463       +4     
  Misses        630      630
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoTransform.js 84.97% <100%> (+0.1%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.5% <0%> (-0.12%) ⬇️
src/Adapters/Auth/meetup.js 89.47% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9371958...be03015. Read the comment docs.

@flovilmart flovilmart changed the title Allow queuing with String array for pointers containedIn Allow queries with String array for pointers containedIn Sep 19, 2017
@flovilmart flovilmart requested a review from acinader October 2, 2017 13:23
@flovilmart flovilmart merged commit 7fac070 into master Oct 3, 2017
@flovilmart flovilmart deleted the investigate-pointer-contained-in branch October 3, 2017 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants