Enables login over POST in addition to GET #4268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4268 +/- ##
==========================================
+ Coverage 92.2% 92.43% +0.22%
==========================================
Files 116 118 +2
Lines 8124 8151 +27
==========================================
+ Hits 7491 7534 +43
+ Misses 633 617 -16
Continue to review full report at Codecov.
|
flovilmart
suggested changes
Oct 20, 2017
spec/ParseUser.spec.js
Outdated
| 'X-Parse-REST-API-Key': 'rest', | ||
| }, | ||
| json: { | ||
| _method: 'POST', |
There was a problem hiding this comment.
You shouldn’t need that
There was a problem hiding this comment.
@flovilmart shouldn't need to indicate post?
|
@flovilmart yeah |
|
the _method prop is an internal parse thing so we can send everything as POST queries an interpolate as _method on the server. |
flovilmart
approved these changes
Oct 24, 2017
This was referenced Jan 8, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is a little something for #4052 . The change is relatively minor and really doesn't do anything on it's own. A single test is added to verify login works over POST using REST.
Most importantly this will allow future development on the sdks to eventually switch to using POST for login requests, instead of GET. Perhaps at some distant point in time we could even consider deprecating and eventually removing the GET approach, but for now keeping it is essential for reverse compatibility.
Just to make a point there really isn't anything too bad about the current approach using GET, so long as the connection is secure. The one thing that really stands out is that if logging is not done properly you risk including username/password combos in the log. Although this would really only happen if you were directly piping output from the process into a log or something like that. There is that chance that if you set up logging improperly and someone else has access to that log that you might have a problem. Although this doesn't really fix that this gives us the option to do so down the road.