Skip to content

Adds infos about vulnerability disclosures #4413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 5, 2017

Conversation

flovilmart
Copy link
Contributor

No description provided.

@flovilmart flovilmart changed the title Adds infos about vulnerability discosures Adds infos about vulnerability disclosures Dec 2, 2017
@codecov
Copy link

codecov bot commented Dec 2, 2017

Codecov Report

Merging #4413 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4413   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files         118      118           
  Lines        8346     8346           
=======================================
  Hits         7734     7734           
  Misses        612      612
Impacted Files Coverage Δ
src/RestWrite.js 93.28% <0%> (-0.19%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f22ee3...ead0b12. Read the comment docs.

@dplewis
Copy link
Member

dplewis commented Dec 2, 2017

The French Approves 🙏

@flovilmart
Copy link
Contributor Author

You French for real?

@dplewis
Copy link
Member

dplewis commented Dec 2, 2017

Not at all. I’m going to learn French next year. It will be fun.

@flovilmart
Copy link
Contributor Author

Ahah! Awesome!

@dplewis
Copy link
Member

dplewis commented Dec 2, 2017

:octocat: approved

Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. It's about time we had a serious statement about how we handle such issues. We may want to specify a minimum amount of time that should be expected before we can a) respond and b) be able to fix the issue, depending on severity.

@flovilmart
Copy link
Contributor Author

Good idea, feel free to edit directly in github!

@montymxb
Copy link
Contributor

montymxb commented Dec 3, 2017

Just changed the language regarding timetables from first contact to patch applied. If the wording looks good I actually want to change both of those values to days, 7 and 30 respectively.

@flovilmart
Copy link
Contributor Author

Yep that's good to me!

@flovilmart flovilmart merged commit 8fd5f31 into master Dec 5, 2017
@flovilmart flovilmart deleted the vulnerability-disclosures branch December 5, 2017 13:52
@montymxb
Copy link
Contributor

montymxb commented Dec 5, 2017

@flovilmart Looking back at this I'm wondering if we should also consider adding a small section to the README as well, just pointing to SECURITY.md?

@flovilmart
Copy link
Contributor Author

Yes, I was realizing it earlier this morning, also probably on http://parseplatform.org and http://docs.parseplatform.org

@montymxb
Copy link
Contributor

montymxb commented Dec 5, 2017

Wouldn't be a bad idea

@nbering
Copy link

nbering commented Dec 6, 2017

The wording on the responsible disclosure policy looks like it's for a hosted service.

@flovilmart
Copy link
Contributor Author

Which part? We can always improve!

@nbering
Copy link

nbering commented Dec 6, 2017

Sorry. I realized after I posted that it was really vague. It refers to accessing individual user accounts. Sounds like Parse.com security policy more than a self-hosted open source server.

@flovilmart
Copy link
Contributor Author

Yeah, in the sense that one would be able to poke the accounts / setups of parse-server users and exploit the said vulnerabilities.

@nbering
Copy link

nbering commented Dec 6, 2017

Yes, but there is no need for that to be allowable. A security researcher should be able to self-host. They never had that option on Parse.com so an exception would have needed to be made to allow vulnerability discovery. The Parse Platform project cannot authorize people to do penetration testing of other people's servers... so unless you have a sample where people can poke around this doesn't seem like a valid policy.

@nbering
Copy link

nbering commented Dec 6, 2017

Sorry... I sound unintentionally negative. Aside from that point this is great work and should serve as an example of responsibility to the community.

@flovilmart
Copy link
Contributor Author

I would like to make it better, with your help, feel free to rephrase, edit in a subsequent PR.

Even if the ‘account’ is inaccurate, because we don’t host user accounts, it would still be possible for one to test against live deployments of parse-servers, based on discoveries of public data (logs shared etc...). This sentence would encompass that, I’d like a better phrasing too.

flovilmart added a commit that referenced this pull request Dec 29, 2017
* Create SECURITY.md

* Update SECURITY.md

* Update SECURITY.md

* Update ISSUE_TEMPLATE.md

* Update ISSUE_TEMPLATE.md

* Clarify time table from contact to fix

* change times to days
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Create SECURITY.md

* Update SECURITY.md

* Update SECURITY.md

* Update ISSUE_TEMPLATE.md

* Update ISSUE_TEMPLATE.md

* Clarify time table from contact to fix

* change times to days
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants