Create a test to check the issue #4501 #4532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds:
- Check if after the user confirms the email and change the email
again a new verification email is sent
|
Oh...well ignore what I was saying before. Didn't realize this was already up, totally missed that 🤣 . I'll suggest some changes here. |
montymxb
suggested changes
Feb 1, 2018
spec/EmailVerificationToken.spec.js
Outdated
| @@ -777,4 +777,63 @@ describe("Email Verification Token Expiration: ", () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('When a user has verified their email, and then change it, the field emailVerified should be false and the new link will be send to the user', done => { | |||
There was a problem hiding this comment.
A suggestion to reword this to be a bit shorter
emailVerified should be set to false after changing from an already verified email
There was a problem hiding this comment.
Man, do you speak a lot hahaha.
Codecov Report
@@ Coverage Diff @@
## master #4532 +/- ##
==========================================
- Coverage 92.89% 92.81% -0.09%
==========================================
Files 118 118
Lines 8445 8445
==========================================
- Hits 7845 7838 -7
- Misses 600 607 +7
Continue to review full report at Codecov.
|
montymxb
approved these changes
Feb 1, 2018
fantastic! Although this behavior is already exhibited, now we'll be able to properly account for it in any further changes or releases from this point on.
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
…existing (parse-community#4532) * Create a test to check the issue parse-community#4501 * Check if after the user confirms the email and change the email again a new verification email is sent * Change the spec text to requested in PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds: