Skip to content

Remove FB Graph API version from URL to use the oldest non deprecated version #4650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

SebC99
Copy link
Contributor

@SebC99 SebC99 commented Mar 15, 2018

Facebook auth adapter uses a hard-coded version of the FB Graph API.
As 2.5 is going to be soon removed from the working versions, removing the version number allows the auth adapter to be always up-to-date.

Closes: #4638

… version (2.5 for now, which will be deprecated soon)
@codecov
Copy link

codecov bot commented Mar 15, 2018

Codecov Report

Merging #4650 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4650      +/-   ##
==========================================
- Coverage   92.66%   92.63%   -0.04%     
==========================================
  Files         119      119              
  Lines        8567     8567              
==========================================
- Hits         7939     7936       -3     
- Misses        628      631       +3
Impacted Files Coverage Δ
src/Adapters/Auth/facebook.js 80% <100%> (ø) ⬆️
src/RestWrite.js 93.05% <0%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36ef99...84b9eb8. Read the comment docs.

@dplewis dplewis requested a review from flovilmart March 15, 2018 18:17
Copy link
Contributor

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dplewis dplewis merged commit 6abf29d into parse-community:master Mar 15, 2018
@mtrezza
Copy link
Member

mtrezza commented Apr 6, 2018

@dplewis, @flovilmart - Is it a advisable to remove the version number instead of updating it? If Facebook releases a new API where the specific endpoint becomes deprecated, I assume the Facebook functionality for parse servers even in production environments would suddenly stop working.

@SebC99
Copy link
Contributor Author

SebC99 commented Apr 7, 2018

@mtrezza as removing it means using the oldest version available, there will be no more deprecation than by updating the number manually. The only difference is that we won't miss any deadline... As an example there's only a few days left to upgrade from 2.5 to 2.6 :)

@mtrezza
Copy link
Member

mtrezza commented Apr 7, 2018 via email

UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants