-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Remove FB Graph API version from URL to use the oldest non deprecated version #4650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… version (2.5 for now, which will be deprecated soon)
Codecov Report
@@ Coverage Diff @@
## master #4650 +/- ##
==========================================
- Coverage 92.66% 92.63% -0.04%
==========================================
Files 119 119
Lines 8567 8567
==========================================
- Hits 7939 7936 -3
- Misses 628 631 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dplewis, @flovilmart - Is it a advisable to remove the version number instead of updating it? If Facebook releases a new API where the specific endpoint becomes deprecated, I assume the Facebook functionality for parse servers even in production environments would suddenly stop working. |
@mtrezza as removing it means using the oldest version available, there will be no more deprecation than by updating the number manually. The only difference is that we won't miss any deadline... As an example there's only a few days left to upgrade from 2.5 to 2.6 :) |
My bad, I thought it would use the newest version available. Still I wonder how we will find out that the Graph endpoint in parse server needs to be updated before it actually deprecates so that production systems are not affected? The earliest possibility for that is around 3 years from today when the current API will presumably expire (tbd).
… On 07.04.2018, at 10:57, SebC. ***@***.***> wrote:
@mtrezza as removing it means using the oldest version available, there will be no more deprecation than by updating the number manually. The only difference is that we won't miss any deadline... As an example there's only a few days left to upgrade from 2.5 to 2.6 :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
… version (2.5 for now, which will be deprecated soon) (parse-community#4650)
Facebook auth adapter uses a hard-coded version of the FB Graph API.
As 2.5 is going to be soon removed from the working versions, removing the version number allows the auth adapter to be always up-to-date.
Closes: #4638