Skip to content

Add include option to Login #4845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions spec/ParseUser.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,36 @@ describe('Parse.User testing', () => {
});
});

it('user login with include', (done) => {
const object = new TestObject();
object.set('foo', 'bar');
const user = new Parse.User();
user.setUsername('asdf');
user.setPassword('zxcv');
user.set('foobaz', object);
user.set('foobar', object);
user.signUp().then(() => {
return rp.post({
url: 'http://localhost:8378/1/login',
headers: {
'X-Parse-Application-Id': Parse.applicationId,
'X-Parse-REST-API-Key': 'rest',
},
json: {
_method: 'GET',
username: 'asdf',
password: 'zxcv',
include: 'foobaz,foobar',
}
}).then((user) => {
equal(user.username, 'asdf');
equal(user.foobaz.foo, 'bar');
equal(user.foobar.foo, 'bar');
done();
});
});
});

it('user login with non-string username with REST API', (done) => {
Parse.User.signUp('asdf', 'zxcv', null, {
success: () => {
Expand Down
23 changes: 21 additions & 2 deletions src/Routers/UsersRouter.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import ClassesRouter from './ClassesRouter';
import rest from '../rest';
import Auth from '../Auth';
import passwordCrypto from '../password';
import RestQuery from '../RestQuery';

export class UsersRouter extends ClassesRouter {

Expand Down Expand Up @@ -201,8 +202,26 @@ export class UsersRouter extends ClassesRouter {
req.config.filesController.expandFilesInObject(req.config, user);

return createSession();
})
.then(() => {
}).then(() => {
if (!req.body.include || typeof req.body.include !== 'string') {
return Promise.resolve();
}
const fields = ['user'];
const includes = req.body.include.split(',');
for (const field of includes) {
fields.push(`user.${field}`);
}
const query = new RestQuery(req.config, Auth.master(req.config), '_Session',
{ sessionToken: user.sessionToken },
{ include: fields.join() }, req.info.clientSDK);
return query.execute().then((resp) => {
const includedUser = resp.results[0].user;
includedUser.sessionToken = user.sessionToken;
UsersRouter.removeHiddenProperties(includedUser);
user = includedUser;
return user;
});
}).then(() => {
return { response: user };
});
}
Expand Down