Use an empty object as default value of options for Google Sign in #6844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should make sure this PR contains a test case for #6852 |
|
I think #6852 can be fixed by this PR as well. Should I write a new test case for this? |
|
yes a test case is needed :) @kvnkuang |
|
@Moumouls Thanks! Test case added. |
Codecov Report
@@ Coverage Diff @@
## master #6844 +/- ##
==========================================
- Coverage 93.92% 93.76% -0.16%
==========================================
Files 169 169
Lines 12210 12221 +11
==========================================
- Hits 11468 11459 -9
- Misses 742 762 +20
Continue to review full report at Codecov.
|
davimacedo
reviewed
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to address the issue parse-community/docs#754.
Without a default value of options, we will have to explicitly define (at least) an empty object at initialization so that Google sign in function won't crash.