Run prettier

[dblythy]

New Pull Request Checklist

• I am not disclosing a vulnerability.
• I am creating this PR in reference to an issue.

Issue Description

Runs prettier on Parse Server (there are a few affected files)

[dblythy]

Also, there are a couple of files which are changed using npm run prettier but changed back using npm run lint-fix. Which should be the priority?

[codecov]

Codecov Report

Merging #7172 (67194ba) into master (e3ed6e4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7172   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files         169      169           
  Lines       12547    12547           
=======================================
  Hits        11784    11784           
  Misses        763      763           

Impacted Files	Coverage Δ
src/Controllers/LiveQueryController.js	96.42% <100.00%> (-0.13%)	⬇️
src/Controllers/UserController.js	95.27% <100.00%> (ø)
src/RestQuery.js	95.53% <100.00%> (+<0.01%)	⬆️
src/Routers/FilesRouter.js	88.28% <100.00%> (ø)
src/Adapters/Files/GridFSBucketAdapter.js	79.50% <0.00%> (-0.82%)	⬇️
src/RestWrite.js	93.84% <0.00%> (+0.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ed6e4...6eba387. Read the comment docs.

[davimacedo]

I think we should choose and rely in one of them. @dplewis @mtrezza thoughts?

[mtrezza]

There are things that lint doesn't do, but prettier does and vice versa. Not, because one is better than the other but because each has a slightly different although similar purpose. In short, one is focused on code quality, the other on code style.

I think we should decide the order in which they run - which will lead to different results - without expecting both to yield the same output.

I suggest the order to be prettier -> lint, because while code style is somewhat idiosyncratic, code quality seems to be less so.

[dblythy]

Okay, cool. Good to know the process for the future. That's what I expected.

This PR is still the result of running:

npm run prettier
then
npm run lint-fix

On the master branch

[mtrezza]

I think that makes sense. @davimacedo ?

[davimacedo]

Yes. That makes sense. I believe it is actually already automated here, right?

[dblythy]

I think it only affects files that are edited though. If you run prettier on the master and then lint-fix, the result is this PR

[mtrezza]

LGTM!

[parseplatformorg]

🎉 This change has been released in version 5.0.0-beta.1

[parseplatformorg]

🎉 This change has been released in version 5.0.0