-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Fix password reset, email verification for custom endpoint #7236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix password reset, email verification for custom endpoint #7236
Conversation
* commit 'ccb045b68c5b4d983a90fa125513fc476e4e2387': fix: upgrade @graphql-tools/links from 6.2.4 to 6.2.5 (parse-community#7007) fix: upgrade pg-promise from 10.7.0 to 10.7.1 (parse-community#7009) fix: upgrade jwks-rsa from 1.10.1 to 1.11.0 (parse-community#7008) fix: upgrade graphql from 15.3.0 to 15.4.0 (parse-community#7011) update stale bot (parse-community#6998) fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields (parse-community#7005) fix(beforeSave): Skip Sanitizing Database results (parse-community#7003) Fix includeAll for querying a Pointer and Pointer array (parse-community#7002) Init (parse-community#6999)
* commit '7f47b0427ea56214d9b0199f0fcfa4af38794e02': Add page localization (parse-community#7128) Improve contribution guide (parse-community#7075) fix: upgrade pg-promise from 10.9.0 to 10.9.1 (parse-community#7170) Add tests against multiple MongoDB versions (parse-community#7161) fix: upgrade mime from 2.4.7 to 2.5.0 (parse-community#7166) fix: upgrade pg-promise from 10.8.7 to 10.9.0 (parse-community#7168) fix: upgrade apollo-server-express from 2.19.1 to 2.19.2 (parse-community#7165) Upgrade @node-rs/bcrypt to latest version (parse-community#7159) Run Prettier after Definitions (parse-community#7164)
@mman This should fix the issue you described in #7210 (comment). Feel free to test it out. |
Codecov Report
@@ Coverage Diff @@
## master #7236 +/- ##
==========================================
- Coverage 94.04% 94.03% -0.01%
==========================================
Files 172 172
Lines 12959 12960 +1
==========================================
Hits 12187 12187
- Misses 772 773 +1
Continue to review full report at Codecov.
|
@mtrezza yes, that was the issue I mentioned and have not filed yet. Thanks for fixing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎉 This change has been released in version 5.0.0-beta.1 |
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
Custom
pagesEndpoint
in PagesRouter breaks password reset and email verification because the links contain the default endpointapps
.Related issue: closes #7235
Approach
Change link builders to use the correct endpoint.
TODOs before merging
[ ] Add entry to changelogNo changelog entry, because the fixed feature has not even been released yet (?)