Skip to content

Fix password reset, email verification for custom endpoint #7236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Mar 2, 2021

New Pull Request Checklist

Issue Description

Custom pagesEndpoint in PagesRouter breaks password reset and email verification because the links contain the default endpoint apps.

Related issue: closes #7235

Approach

Change link builders to use the correct endpoint.

TODOs before merging

  • Add test cases
  • [ ] Add entry to changelog No changelog entry, because the fixed feature has not even been released yet (?)

mtrezza and others added 23 commits November 19, 2020 01:05
* commit 'ccb045b68c5b4d983a90fa125513fc476e4e2387':
  fix: upgrade @graphql-tools/links from 6.2.4 to 6.2.5 (parse-community#7007)
  fix: upgrade pg-promise from 10.7.0 to 10.7.1 (parse-community#7009)
  fix: upgrade jwks-rsa from 1.10.1 to 1.11.0 (parse-community#7008)
  fix: upgrade graphql from 15.3.0 to 15.4.0 (parse-community#7011)
  update stale bot (parse-community#6998)
  fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields (parse-community#7005)
  fix(beforeSave): Skip Sanitizing Database results (parse-community#7003)
  Fix includeAll for querying a Pointer and Pointer array (parse-community#7002)
  Init (parse-community#6999)
* commit '7f47b0427ea56214d9b0199f0fcfa4af38794e02':
  Add page localization (parse-community#7128)
  Improve contribution guide (parse-community#7075)
  fix: upgrade pg-promise from 10.9.0 to 10.9.1 (parse-community#7170)
  Add tests against multiple MongoDB versions (parse-community#7161)
  fix: upgrade mime from 2.4.7 to 2.5.0 (parse-community#7166)
  fix: upgrade pg-promise from 10.8.7 to 10.9.0 (parse-community#7168)
  fix: upgrade apollo-server-express from 2.19.1 to 2.19.2 (parse-community#7165)
  Upgrade @node-rs/bcrypt to latest version (parse-community#7159)
  Run Prettier after Definitions (parse-community#7164)
@mtrezza mtrezza changed the title Fix password reset email verification for custom endpoint Fix password reset, email verification for custom endpoint Mar 2, 2021
@mtrezza
Copy link
Member Author

mtrezza commented Mar 2, 2021

@mman This should fix the issue you described in #7210 (comment). Feel free to test it out.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #7236 (118320c) into master (3833868) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7236      +/-   ##
==========================================
- Coverage   94.04%   94.03%   -0.01%     
==========================================
  Files         172      172              
  Lines       12959    12960       +1     
==========================================
  Hits        12187    12187              
- Misses        772      773       +1     
Impacted Files Coverage Δ
src/Config.js 92.89% <100.00%> (+0.03%) ⬆️
src/ParseServerRESTController.js 97.01% <0.00%> (-1.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3833868...118320c. Read the comment docs.

@mtrezza mtrezza requested review from davimacedo and dplewis March 2, 2021 20:13
@mman
Copy link
Contributor

mman commented Mar 2, 2021

@mtrezza yes, that was the issue I mentioned and have not filed yet. Thanks for fixing it.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mtrezza mtrezza merged commit d789ca6 into parse-community:master Mar 2, 2021
@mtrezza mtrezza deleted the fix-password-reset-email-verification-for-custom-endpoint branch March 2, 2021 23:53
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password reset, email verification not working with custom pages endpoint
4 participants