Skip to content

refactor: remove deprecated url.parse() method #7751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Jan 6, 2022
Merged
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
59c94dd
feat: support postgresql in database uri
cbaker6 Dec 29, 2021
4ee0264
lint
cbaker6 Dec 29, 2021
97922c7
revert LoggerController.js
cbaker6 Dec 29, 2021
3388d58
fix variance in error message for gcenter
cbaker6 Dec 29, 2021
f0e4c55
fix gcenter method to act it's original way
cbaker6 Dec 29, 2021
703bfde
add missing colon
cbaker6 Dec 29, 2021
ca00fc1
improve PostgresInitOptions.spec.js testcases
cbaker6 Dec 29, 2021
fe5105e
make GraphQL compare to lowercase for better comparison
cbaker6 Dec 29, 2021
3579d2a
reconfigure server when needed to prevent test failures
cbaker6 Dec 29, 2021
e5962b6
revert graph test change toLower
cbaker6 Dec 30, 2021
8dccff3
add coverage to AuthenticationAdapters.spec.js
cbaker6 Dec 30, 2021
1da1fba
ParseServerRESTController.spec.js needs reconfig before running
cbaker6 Dec 30, 2021
3a7acc4
update REST controller tests
cbaker6 Dec 30, 2021
7a21d31
add back reconfigure to rest transactions for mongo
cbaker6 Dec 30, 2021
41ad90d
remove working reconfigure
cbaker6 Dec 30, 2021
5c7a7f3
make PostgresInitOptions.spec.js use global reconfigure
cbaker6 Dec 30, 2021
f3bf93d
lint
cbaker6 Dec 30, 2021
0f3275e
remove extra parameter
cbaker6 Dec 30, 2021
716b300
remove transaction tests from REST controller
cbaker6 Dec 30, 2021
ef380e7
update batch.spec.js to async/await
cbaker6 Dec 30, 2021
6ba5d65
add back transaction tests to RESTController
cbaker6 Dec 30, 2021
97c7908
disable RestController transaction tests on Postgres
cbaker6 Dec 30, 2021
7d554f0
modify GraphQL test so it is not flaky
cbaker6 Dec 30, 2021
0072af0
wait for schema changes
cbaker6 Dec 30, 2021
0efba80
convert PostgresConfig to URI
cbaker6 Dec 30, 2021
af3a903
remove url.parse from LoggerController
cbaker6 Dec 31, 2021
4a00035
Merge branch 'alpha' into postgresURI
cbaker6 Dec 31, 2021
6b26dd5
remove uneccesary functoin
cbaker6 Dec 31, 2021
24737d1
increase schema watch test to 2 seconds
cbaker6 Dec 31, 2021
1a9a66c
add back parseURL to batch.js and add testcases
cbaker6 Jan 1, 2022
f7978cd
upgrade tests in PushController
cbaker6 Jan 1, 2022
92ae2cf
Merge branch 'alpha' into postgresURI
mtrezza Jan 1, 2022
f50e2a0
revert changes
cbaker6 Jan 2, 2022
0a699d2
more reverts
cbaker6 Jan 2, 2022
b176032
Merge branch 'alpha' into postgresURI
cbaker6 Jan 2, 2022
7618a25
Merge branch 'alpha' into postgresURI
cbaker6 Jan 2, 2022
6f349f2
Merge branch 'alpha' into postgresURI
mtrezza Jan 2, 2022
e106f6e
Merge branch 'alpha' into postgresURI
mtrezza Jan 2, 2022
89024f8
Merge branch 'alpha' into postgresURI
mtrezza Jan 3, 2022
5d23976
merge conflicts
cbaker6 Jan 4, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions spec/AuthenticationAdapters.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1707,6 +1707,24 @@ describe('Apple Game Center Auth adapter', () => {
expect(e.message).toBe('Apple Game Center - invalid publicKeyUrl: invalid.com');
}
});

it('validateAuthData invalid public key http url', async () => {
const authData = {
id: 'G:1965586982',
publicKeyUrl: 'http://static.gc.apple.com/public-key/gc-prod-4.cer',
timestamp: 1565257031287,
signature: '1234',
salt: 'DzqqrQ==',
bundleId: 'cloud.xtralife.gamecenterauth',
};

try {
await gcenter.validateAuthData(authData);
fail();
} catch (e) {
expect(e.message).toBe('Apple Game Center - invalid publicKeyUrl: http://static.gc.apple.com/public-key/gc-prod-4.cer');
}
});
});

describe('phant auth adapter', () => {
Expand Down
11 changes: 9 additions & 2 deletions spec/ParseGraphQLServer.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2600,12 +2600,19 @@ describe('ParseGraphQLServer', () => {
// "SecondaryObject:bBRgmzIRRM" < "SecondaryObject:nTMcuVbATY" true
// base64("SecondaryObject:bBRgmzIRRM"") < base64(""SecondaryObject:nTMcuVbATY"") false
// "U2Vjb25kYXJ5T2JqZWN0OmJCUmdteklSUk0=" < "U2Vjb25kYXJ5T2JqZWN0Om5UTWN1VmJBVFk=" false
const originalIds = [getSecondaryObjectsResult.data.secondaryObject2.objectId,
getSecondaryObjectsResult.data.secondaryObject4.objectId];
expect(
findSecondaryObjectsResult.data.secondaryObjects.edges[0].node.objectId
).toBeLessThan(
).not.toBe(
findSecondaryObjectsResult.data.secondaryObjects.edges[1].node.objectId
);

expect(
originalIds.includes(findSecondaryObjectsResult.data.secondaryObjects.edges[0].node.objectId)
).toBeTrue();
expect(
originalIds.includes(findSecondaryObjectsResult.data.secondaryObjects.edges[1].node.objectId)
).toBeTrue();
const createPrimaryObjectResult = await apolloClient.mutate({
mutation: gql`
mutation CreatePrimaryObject(
Expand Down
Loading