Skip to content

feat: add custom objectId by providing newObjectIdCallback from server config #7834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: alpha
Choose a base branch
from

Conversation

JasCodes
Copy link

@JasCodes JasCodes commented Mar 4, 2022

Features

  • Add custom objectId by providing newObjectIdCallback from server config.

Issue Description

Related issue:

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: Add custom objectId by providing newObjectIdCallback from server config feat: add custom objectId by providing newObjectIdCallback from server config Mar 4, 2022
@JasCodes
Copy link
Author

JasCodes commented Mar 4, 2022

@mtrezza Can you approve workflows?

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@mtrezza
Copy link
Member

mtrezza commented Mar 4, 2022

Sure, we can run the workflow, but we do this usually as the last steps to ensure your code works in all supported environments. Until the PR is ready, you can run the tests locally in your local environment to see whether they pass. That's also faster during development, as you can choose to run only your own tests that you add as part of this PR.

This PR still needs:

  • Tests, see existing tests in /spec folder for guidance
  • Adding the new Parse server option, see Contribution Guide for the necessary steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make objectId lexographically sortable
2 participants