Skip to content

ci: upgrade Postgres versions #8191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 23, 2022
Merged

ci: upgrade Postgres versions #8191

merged 7 commits into from
Sep 23, 2022

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Sep 22, 2022 •
edited
Loading

New Pull Request Checklist

Issue Description

The CI isn't testing against the current latest versions of dependencies (e.g. Postgis 3.3) and still testing against dependencies that has reached the Parse EOL (e.g. Postges 11, Node 12, Mongo 4.0). This prevents the CI from determining if there are issues with the latest versions along with running unnecessary tests for each PR.

Closes: #8192

Approach

Update versions of Postgis, remove versions that have reached EOL: Postres 11, Postgis 3.0, Node 12, Mongo 4.0, Mongo MMAPv1.

TODOs before merging

  • Someone with access to the repo settings will need to update the branch requirements
  • Ensure CI passes
  • Update README badges and descriptions to represent latest EOL's
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 22, 2022 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Related issue: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Sep 22, 2022 •
edited
Loading

Codecov Report

Base: 94.18% // Head: 94.18% // No change to project coverage 👍

Coverage data is based on head (3236612) compared to base (eb20e92).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##            alpha    #8191   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files         182      182           
  Lines       13737    13737           
=======================================
  Hits        12938    12938           
  Misses        799      799
Impacted Files Coverage Δ
src/batch.js 92.98% <0.00%> (-1.76%) ⬇️
src/Controllers/DatabaseController.js 93.90% <0.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Sep 22, 2022

@parse-community/server this is ready for review

mtrezza
mtrezza requested changes Sep 22, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #8192 (comment)

@mtrezza mtrezza changed the title ci: update versions and remove EOL deps ci: upgrade Postgres versions Sep 22, 2022
@mtrezza
Copy link
Member

mtrezza commented Sep 22, 2022 •
edited
Loading

@cbaker6 I've renamed the PR to only do the version upgrade, I think you can remove changes that are removing support for versions. Then we can merge this PR immediately as only upgrading existing versions.

@mtrezza mtrezza linked an issue Sep 22, 2022 that may be closed by this pull request
CI should run against latest Postgres versions #8192
Closed
3 tasks
mtrezza
mtrezza approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Rerunning the tests until all pass...

@mtrezza mtrezza merged commit 377ce67 into parse-community:alpha Sep 23, 2022
@cbaker6 cbaker6 deleted the updateCI branch September 23, 2022 23:13
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-alpha.27

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Sep 29, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 29, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 19, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released-5.x.x Released as LTS version label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-5.x.x Released as LTS version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI should run against latest Postgres versions
3 participants
@cbaker6 @mtrezza @parseplatformorg