Skip to content

refactor: Upgrade pg-promise, pg-monitor #8364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

refactor: Upgrade pg-promise, pg-monitor #8364

wants to merge 4 commits into from

Conversation

vitaly-t
Copy link
Contributor

New Pull Request Checklist

Issue Description

Upgrades pg-promise + pg-monitor (they are interdependent, need to be upgraded at once)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 30, 2022

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@mtrezza mtrezza changed the title upgrade pg-promise + monitor refactor: upgrade pg-promise, pg-monitor Dec 30, 2022
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title refactor: upgrade pg-promise, pg-monitor refactor: Upgrade pg-promise, pg-monitor Dec 30, 2022
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 94.08% // Head: 94.21% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (7fb764f) compared to base (ee72467).
Patch has no changes to coverable lines.

❗ Current head 7fb764f differs from pull request most recent head 9cd0f66. Consider uploading reports for the commit 9cd0f66 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8364      +/-   ##
==========================================
+ Coverage   94.08%   94.21%   +0.12%     
==========================================
  Files         181      181              
  Lines       14271    14271              
==========================================
+ Hits        13427    13445      +18     
+ Misses        844      826      -18     
Impacted Files Coverage Δ
src/GraphQL/loaders/filesMutations.js 41.93% <0.00%> (-38.71%) ⬇️
src/GraphQL/transformers/mutation.js 87.85% <0.00%> (-9.35%) ⬇️
src/LiveQuery/ParseLiveQueryServer.js 95.85% <0.00%> (+0.21%) ⬆️
src/ParseServer.js 92.09% <0.00%> (+0.46%) ⬆️
src/Adapters/Files/GridFSBucketAdapter.js 94.20% <0.00%> (+0.72%) ⬆️
src/LiveQuery/ParseCloudCodePublisher.js 100.00% <0.00%> (+15.78%) ⬆️
src/Adapters/Cache/RedisCacheAdapter.js 91.30% <0.00%> (+73.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza
Copy link
Member

mtrezza commented Dec 30, 2022

This includes 2 major version upgrades; is this a breaking change for developers?

@vitaly-t
Copy link
Contributor Author

vitaly-t commented Dec 30, 2022

This includes 2 major version upgrades; is this a breaking change for developers?

Breaking changes in the library, as per v11 notes, but not for parse-server developers or users (at least shouldn't be).

@mtrezza
Copy link
Member

mtrezza commented Dec 31, 2022

Thanks for confirming; kindly request a review once this is ready.

@vitaly-t
Copy link
Contributor Author

vitaly-t commented Dec 31, 2022

For some reasons, I no longer can install dependencies, getting this error:

image

Any idea what might be causing the problem?

@mtrezza
Copy link
Member

mtrezza commented Dec 31, 2022

Maybe related to your GitHub auth?

@vitaly-t vitaly-t closed this by deleting the head repository Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants