Skip to content

feat: Improve facebook adapter #8462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: alpha
Choose a base branch
from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Mar 7, 2023

Pull Request

Issue

Currently, the facebook adapter does not validate it's config via validateOptions, meaning that a developer can set an invalid configuration and is not aware of it until a user attempts to log in via facebook.

Closes: #8461

Approach

Improves facebook adapter to modern AuthAdapter syntax, some minor other changes necessary to validate inbuilt auth adapters.

Tasks

  • Add tests

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@parse-github-assistant parse-github-assistant bot changed the title feat: improve facebook adapter feat: Improve facebook adapter Mar 7, 2023
@dblythy dblythy marked this pull request as draft March 7, 2023 06:50
@dblythy
Copy link
Member Author

dblythy commented Mar 7, 2023

Depends on #8464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facebook auth adapter can accept invalid configuration
1 participant