Skip to content

perf: Use aggregation pipeline with $graphLookup for recursive role and auth queries #8563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: alpha
Choose a base branch
from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented May 22, 2023

Pull Request

Issue

Closes: #6556

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title perf: use $graphLookup for auth perf: Use $graphLookup for auth May 22, 2023
@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 95.65% and no project coverage change.

Comparison is base (6a4a00c) 94.37% compared to head (5f7d0e0) 94.37%.
Report is 1 commits behind head on alpha.

❗ Current head 5f7d0e0 differs from pull request most recent head 74a7555. Consider uploading reports for the commit 74a7555 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #8563   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files         185      185           
  Lines       14761    14769    +8     
=======================================
+ Hits        13930    13938    +8     
  Misses        831      831           
Files Changed Coverage Δ
src/Auth.js 98.52% <95.45%> (-0.34%) ⬇️
src/Controllers/DatabaseController.js 94.24% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza changed the title perf: Use $graphLookup for auth perf: Use aggregation pipeline with $graphLookup for recursive roles and auth queries May 22, 2023
@mtrezza mtrezza changed the title perf: Use aggregation pipeline with $graphLookup for recursive roles and auth queries perf: Use aggregation pipeline with $graphLookup for recursive role and auth queries May 22, 2023
@mtrezza
Copy link
Member

mtrezza commented May 28, 2023

Is this ready for review?

@dblythy
Copy link
Member Author

dblythy commented May 31, 2023

Just need to get postgres working!

@dblythy
Copy link
Member Author

dblythy commented Jun 27, 2023

@cbaker6 @mtrezza would either of you know if this feature is compatible with Postgres? Or should the old auth lookup be used?

@cbaker6
Copy link
Contributor

cbaker6 commented Jun 27, 2023

@dplewis is better suited to answer this question than I am as he added aggregation pipes to Postgres in #4207. To me, it looks like there will need be added work to make it comparable based on graphLookup not being in the Postgres adapter and #6513 (comment)

@mtrezza
Copy link
Member

mtrezza commented Mar 24, 2024

@Moumouls Another auth conflict... if you want to take a quick look...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants