fix: Parse Server option extendSessionOnUse not working for session lengths < 24 hours

spec/Auth.spec.js

@@ -260,3 +260,58 @@ describe('Auth', () => {
     });
   });
 });
+
+describe('extendSessionOnUse', () => {
+  const tests = [
+    {
+      title: 'Updated more than 24 hrs ago',
+      sessionLength: 86460,
+      sessionUpdatedAt: 86410,
+      result: true,
+    },
+    {
+      title: 'Updated less than 24 hrs ago',
+      sessionLength: 86460,
+      sessionUpdatedAt: 86390,
+      result: false,
+    },
+    {
+      title: 'Update more than an hour ago',
+      sessionLength: 3660,
+      sessionUpdatedAt: 3610,
+      result: true,
+    },
+    {
+      title: 'Updated less than an hour ago',
+      sessionLength: 3660,
+      sessionUpdatedAt: 3590,
+      result: false,
+    },
+    {
+      title: 'Updated more than a minute ago.',
+      sessionLength: 120,
+      sessionUpdatedAt: 70,
+      result: true,
+    },
+    {
+      title: 'Updated less than a minute ago.',
+      sessionLength: 120,
+      sessionUpdatedAt: 50,
+      result: false,
+    },
+  ];
+
+  tests.forEach(({ title, sessionLength, sessionUpdatedAt, result }) => {
+    it(`shouldUpdateSessionExpiry() when ${title}`, async () => {
+      const { shouldUpdateSessionExpiry } = require('../lib/Auth');
+      const update = new Date();
+      update.setTime(update.getTime() - sessionUpdatedAt * 1000);
+      const res = shouldUpdateSessionExpiry(
+        { sessionLength: sessionLength },
+        { updatedAt: update }
+      );
+
+      expect(res).toBe(result);
+    });
+  });
+});

src/Auth.js

@@ -67,6 +67,25 @@ function nobody(config) {
   return new Auth({ config, isMaster: false });
 }
 
+/**
+ * Checks whether session should be updated based on last update time & session length.
+ */
+function shouldUpdateSessionExpiry(config, session) {
+  let resetAfter = 60;
+  if (config.sessionLength > 86400) {
+    resetAfter = 86400; // Every 24 hours
+  } else if (config.sessionLength > 3600) {
+    resetAfter = 3600; // 1 hour
+  } else {
+    resetAfter = 60; // Every minute
+  }
+
+  const lastUpdated = new Date(session?.updatedAt);
+  const skipRange = new Date();
+  skipRange.setTime(skipRange.getTime() - resetAfter * 1000);
+  return lastUpdated <= skipRange;
+}
+
 const throttle = {};
 const renewSessionIfNeeded = async ({ config, session, sessionToken }) => {
   if (!config?.extendSessionOnUse) {
@@ -88,10 +107,7 @@ const renewSessionIfNeeded = async ({ config, session, sessionToken }) => {
         const { results } = await query.execute();
         session = results[0];
       }
-      const lastUpdated = new Date(session?.updatedAt);
-      const yesterday = new Date();
-      yesterday.setDate(yesterday.getDate() - 1);
-      if (lastUpdated > yesterday || !session) {
+      if (!shouldUpdateSessionExpiry(config, session) || !session) {
         return;
       }
       const expiresAt = config.generateSessionExpiresAt();
@@ -579,6 +595,7 @@ module.exports = {
   maintenance,
   nobody,
   readOnly,
+  shouldUpdateSessionExpiry,
   getAuthForSessionToken,
   getAuthForLegacySessionToken,
   findUsersWithAuthData,