Skip to content

refactor: Remove Javascript SDK as a dependency #9721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: alpha
Choose a base branch
from

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 16, 2025

Pull Request

Issue

Closes: #8787

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

Copy link

parse-github-assistant bot commented Apr 16, 2025

🚀 Thanks for opening this pull request!

@dplewis dplewis marked this pull request as draft April 16, 2025 18:37
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 75.80872% with 172 lines in your changes missing coverage. Please review.

Project coverage is 92.74%. Comparing base (ed69e03) to head (00e16f8).
Report is 1 commits behind head on alpha.

Files with missing lines Patch % Lines
src/Utils.js 0.00% 49 Missing ⚠️
src/Adapters/Storage/Mongo/MongoTransform.js 71.15% 15 Missing ⚠️
src/Controllers/DatabaseController.js 57.14% 12 Missing ⚠️
src/RestWrite.js 83.01% 9 Missing ⚠️
src/Adapters/Auth/twitter.js 40.00% 6 Missing ⚠️
src/RestQuery.js 45.45% 6 Missing ⚠️
src/GraphQL/helpers/objectsQueries.js 28.57% 5 Missing ⚠️
src/Adapters/Auth/facebook.js 60.00% 4 Missing ⚠️
src/Adapters/Auth/gcenter.js 42.85% 4 Missing ⚠️
src/Adapters/Auth/vkontakte.js 33.33% 4 Missing ⚠️
... and 35 more
Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #9721      +/-   ##
==========================================
- Coverage   93.01%   92.74%   -0.28%     
==========================================
  Files         187      188       +1     
  Lines       15081    15189     +108     
  Branches      174      174              
==========================================
+ Hits        14028    14087      +59     
- Misses       1041     1090      +49     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dplewis
Copy link
Member Author

dplewis commented Apr 16, 2025

@mtrezza The goal is to remove import * as Parse from '../../ClientSDK'; from every file.

This means eliminating all these exports

https://github.com/parse-community/parse-server/pull/9721/files#diff-1c0699bcc374b849308efa6b59c447c2666170d00c470a86a834a1aa8a351726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on Parse JS SDK
1 participant