Skip to content

serverURL is actually not required in CLI #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2016
Merged

Conversation

flovilmart
Copy link
Contributor

small nit for the CLI error

@flovilmart flovilmart changed the title serverURL is actually not required serverURL is actually not required in CLI Mar 12, 2016
@codecov-io
Copy link

Current coverage is 91.64%

Merging #990 into master will increase coverage by +0.02% as of cd0be33

@@            master    #990   diff @@
======================================
  Files           73      73       
  Stmts         4432    4438     +6
  Branches       888     889     +1
  Methods          0       0       
======================================
+ Hit           4061    4067     +6
  Partial         10      10       
  Missed         361     361       

Review entire Coverage Diff as of cd0be33

Powered by Codecov. Updated on successful CI builds.

@gfosco
Copy link
Contributor

gfosco commented Mar 12, 2016

Why don't we require it? If you have any cloud code at all which calls back in to Parse, it's necessary, so it seems like a common snag people will hit.

@flovilmart
Copy link
Contributor Author

because it's inferred by the default port (1337) and default mount path (/parse).

Also, setting --port 8080 --mountPath /1 would produce the right serverURL: http://localhost:8080/1

@gfosco gfosco closed this Mar 14, 2016
@gfosco gfosco reopened this Mar 14, 2016
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@@ -56,7 +56,7 @@ if (!options.serverURL) {
if (!options.appId || !options.masterKey || !options.serverURL) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be updated too right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need serverURL, but we just don't need to say it

flovilmart added a commit that referenced this pull request Mar 17, 2016
serverURL is actually not required in CLI
@flovilmart flovilmart merged commit 7b3448e into master Mar 17, 2016
@flovilmart flovilmart deleted the flovilmart.nitCLI branch March 17, 2016 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants