Improve specs (jsonapi-rb#33)

* Add spec for the railtie and (de)serialization.

* Make #jsonapi_pointers public.

* Cleanup dummy test app.

Author: beauby

jsonapi-rails.gemspec

@@ -20,5 +20,4 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'sqlite3'
   spec.add_development_dependency 'rake',        '~> 11.3'
   spec.add_development_dependency 'rspec-rails', '~> 3.5'
-  spec.add_development_dependency 'dry-validation', '~> 0.10'
 end

lib/jsonapi/rails/action_controller.rb

@@ -33,8 +33,6 @@ def _deserializable(key, options, fallback, &block)
         end
       end
 
-      private
-
       def jsonapi_pointers
         request.env[JSONAPI_POINTERS_KEY]
       end

spec/action_controller_spec.rb

@@ -1,17 +1,72 @@
 require 'rails_helper'
 
-RSpec.describe ActionController::Base do
-  it 'exposes the deserialization mapping via the jsonapi_pointers method' do
-    pointers = { id: '/data/id', type: '/data/type' }
-
-    allow(subject).to receive(:request) do
-      OpenStruct.new(
-        env: {
-          JSONAPI::Rails::ActionController::JSONAPI_POINTERS_KEY => pointers
+describe ActionController::Base, type: :controller do
+  describe '.deserializable_resource' do
+    controller do
+      deserializable_resource :user
+
+      def create
+        render plain: 'ok'
+      end
+    end
+
+    let(:payload) do
+      {
+        _jsonapi: {
+          'data' => {
+            'type' => 'users',
+            'attributes' => { 'foo' => 'bar', 'bar' => 'baz' }
+          }
+        }
+      }
+    end
+
+    it 'makes the deserialized resource available in params' do
+      post :create, params: payload
+
+      expected = { 'type' => 'users', 'foo' => 'bar', 'bar' => 'baz' }
+      expect(controller.params[:user]).to eq(expected)
+    end
+
+    it 'makes the deserialization mapping available via #jsonapi_pointers' do
+      post :create, params: payload
+
+      expected = { foo: '/data/attributes/foo',
+                   bar: '/data/attributes/bar',
+                   type: '/data/type' }
+      expect(controller.jsonapi_pointers).to eq(expected)
+    end
+  end
+
+  describe '#render jsonapi:' do
+    controller do
+      def index
+        serializer = Class.new(JSONAPI::Serializable::Resource) do
+          type :users
+          attribute :name
+        end
+        user = OpenStruct.new(id: 1, name: 'Lucas')
+
+        render jsonapi: user, class: serializer
+      end
+    end
+
+    subject { JSON.parse(response.body) }
+    let(:serialized_user) do
+      {
+        'data' => {
+          'id' => '1',
+          'type' => 'users',
+          'attributes' => { 'name' => 'Lucas' }
         }
-      )
+      }
     end
 
-    expect(subject.send(:jsonapi_pointers)).to equal pointers
+    it 'renders a JSON API document' do
+      get :index
+
+      expect(response.content_type).to eq('application/vnd.api+json')
+      is_expected.to eq(serialized_user)
+    end
   end
 end

spec/dummy/app/controllers/tweets_controller.rb

@@ -6,7 +6,6 @@
 require 'spec_helper'
 require 'rspec/rails'
 # Add additional requires below this line. Rails is not loaded until this point!
-require 'dry-validation'
 
 # Requires supporting ruby files with custom matchers and macros, etc, in
 # spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
@@ -56,40 +55,3 @@
   # arbitrary gems may also be filtered via:
   # config.filter_gems_from_backtrace("gem name")
 end
-
-# Custom RSpec matchers
-module JSONAPI
-  module RSpec
-    class BeValidJsonapiMatcher
-      def matches?(body)
-        JSONAPI.parse_response!(JSON.parse(body))
-        true
-      end
-    end
-
-    def be_valid_jsonapi
-      BeValidJsonapiMatcher.new
-    end
-
-    class MatchSchemaMatcher
-      def matches?(body, &block)
-        schema = Dry::Validation.Schema(&block)
-        @body = JSON.parse(body) unless body.is_a?(Hash)
-        @result = schema.call(@body.with_indifferent_access)
-        @result.success?
-      end
-
-      def failure_message
-        "#{@body} #{@result.errors}"
-      end
-    end
-
-    def match_schema(&block)
-      MatchSchemaMatcher.new(&block)
-    end
-  end
-end
-
-RSpec.configure do |config|
-  config.include JSONAPI::RSpec
-end

spec/dummy/app/deserializable/deserializable_tweet.rb

@@ -0,0 +1,11 @@
+require 'rails_helper'
+
+describe JSONAPI::Rails::Railtie do
+  it 'registers the JSON API MIME type' do
+    expect(Mime[:jsonapi]).to eq('application/vnd.api+json')
+  end
+
+  it 'registers the params parser for the JSON API MIME type' do
+    expect(::ActionDispatch::Request.parameter_parsers[:jsonapi]).not_to be_nil
+  end
+end