Skip to content

Add Expr Throw - PHP 8 #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2021
Merged

Add Expr Throw - PHP 8 #146

merged 3 commits into from
May 5, 2021

Conversation

janatjak
Copy link
Contributor

@janatjak janatjak commented May 4, 2021

Add support for PHP 8 Throw Expression

Example:

$value = $nullableValue ?? throw new InvalidArgumentException();

@pepakriz
Copy link
Owner

pepakriz commented May 4, 2021

@janatjak Thank you. Can you include/improve tests to cover this case?

If I see correctly, this PR resolves #145

@janatjak
Copy link
Contributor Author

janatjak commented May 4, 2021

@pepakriz

yes, this PR should resolves expression problems
tests added

@janatjak
Copy link
Contributor Author

janatjak commented May 4, 2021

@pepakriz i fixed lint error with matrix.php-version == '8.0'

is it ok or do you have another suggestion how to solve this issue?

@pepakriz
Copy link
Owner

pepakriz commented May 4, 2021

@janatjak I think CI is failing because the project depends on a very old version of php_codesniffer.

@pepakriz
Copy link
Owner

pepakriz commented May 4, 2021

@janatjak I'm taking it back. Your solution is OK

@janatjak
Copy link
Contributor Author

janatjak commented May 4, 2021

@janatjak I'm taking it back. Your solution is OK

thanks, btw phpstan fixed

@pepakriz pepakriz merged commit 0de69d8 into pepakriz:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants