Skip to content

Consider default exceptions as possibly thrown exceptions #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2019

Conversation

marcospassos
Copy link
Collaborator

@marcospassos marcospassos commented Feb 10, 2019

This PR fix #57 by suppressing warnings about unused exception configurated through methodThrowTypeDeclarations, better illustrated below:

class Example {
        /**
	 * @throws CheckedException
	 */
	private function methodWithDefaultThrowType(callable $callable): void // error: Unused @throws CheckedException annotation
	{
		$callable();
	}
}
exceptionRules:
     methodThrowTypeDeclarations:
        Example:
            methodWithDefaultThrowType: [FooException]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused throws should consider methods declared in methodThrowTypeDeclarations
2 participants