Dev dependencies update #74
Conversation
src/ThrowsAnnotationReader.php
Outdated
| @@ -93,12 +92,7 @@ public function readByReflection($reflection, Scope $scope): array | |||
| */ | |||
| private function parse($reflection, string $sourceFile, ?string $namespace = null): array | |||
| { | |||
| try { | |||
| $docBlock = $this->getDocblock($reflection); | |||
| } catch (ReflectionException $exception) { | |||
There was a problem hiding this comment.
@marcospassos In which case can this happen?
There was a problem hiding this comment.
I know where it can occur, but I don't know the concrete case.
There was a problem hiding this comment.
Not sure if those cases exist currently, but it may exist.
There was a problem hiding this comment.
So instead of this, I'd like to convert this exception into ShouldNotHappenException inside ThrowsAnnotationReader::getDocblock() method. ok?
There was a problem hiding this comment.
Sure, we can revert it if we find a real case.
phpstan.neon.dist
Outdated
| @@ -15,8 +15,10 @@ parameters: | |||
| reportUnusedCatchesOfUncheckedExceptions: true | |||
| uncheckedExceptions: | |||
| - LogicException | |||
| - ReflectionException | |||
There was a problem hiding this comment.
Why mark ReflectionException as unchecked?
There was a problem hiding this comment.
TestCase::createMock in phpunit >= v8.0.0 has @throws RuntimeException. So line https://github.com/pepakriz/phpstan-exception-rules/blob/master/tests/src/RuleTestCase.php#L87 leads to error Missing @throws ReflectionException annotation. But you're right, I'll make an DynamicMethodThrowTypeExtension for TestCase::createMock method which will throw RuntimeException only when class is not autoloaded.
Yep, I'll split phpunit-update&code-changes to next PR. The second reason is phpunit8 needs php>=7.2 - which I overlooked |
No description provided.