Add support for method whitelisting #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pepakriz can you review it? |
pepakriz
reviewed
Nov 16, 2019
|
@marcospassos Cool, thank you. I'm gonna merge it. |
marcospassos
force-pushed
the
method-whitelisting
branch
from
6a2c0e4 to
b3029fc
Compare
|
Changes applied :) |
pepakriz
approved these changes
Nov 16, 2019
pepakriz
reviewed
Nov 18, 2019
| @@ -161,4 +168,10 @@ public function testThrowsInGlobalScope(): void | |||
| $this->analyse(__DIR__ . '/data/throws-in-global-scope.php'); | |||
| } | |||
|
|
|||
| public function testMethodWhitelist(): void | |||
| { | |||
| $this->methodWhitelist = [TestCase::class => '/^test/']; | |||
There was a problem hiding this comment.
@marcospassos Inconsistent structure. If I follow readme it should be [TestCase::class => ['/^test/']]
There was a problem hiding this comment.
My fault, it's supposed to be a map of class names and patterns as key-value pairs. I don't see a significant advantage in supporting multiples patterns per class, and it brings performance penalties. It's better to combine multiples patterns into a single one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
A new
methodWhitelistoption allows specifying classes and patterns as key-value pairs for matching methods which does not require@throwsannotations to be specified.