test that journal is set up correctly #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
| $journal = $collector->getJournal(); | ||
| $plugins = $journal->getPlugins('acme'); | ||
| $this->assertEquals([ | ||
| 'httplug.plugin.stopwatch', |
There was a problem hiding this comment.
@Nyholm its expected that the journal also tracks the stopwatch, right? or should we hide that from the journal?
There was a problem hiding this comment.
Yes, The stopwatch plugin should always be available when we do profiling.
It should not be hidden from the journal.
|
Awesome @dbu. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
A test about the debug toolbar because tests in #112 where green but the toolbar broken.
Why?
We should prevent regressions.