Skip to content

Display stack duration in profiler #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2017
Merged

Display stack duration in profiler #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Resources/public/style/httplug.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@
font-size: 12px;
}

.httplug-duration {
min-width: 6ch;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ch"? What is that?

Someone once told me to always use "rem".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 ch is the width of a "0" in the current font. It looks easier to me as I want the box at least large as if it was filled with 6 characters.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm. Interesting. Thanks.

What if it takes more then one sec? "1000 ms" That is 7 chars, right? Will we get a line break? If so, change this to 7ch and we will be all happy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use number_format twig filter, so you get a thousand separator. But anyway, I set this as a min-width to get the same width when duration is lower than 100ms and lower than 1000ms. When duration is over 1000ms, the box get larger.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. It was e reading this to fast. It is all good then =)

text-align:center;
}

/**
* HTTP method colors from swagger-ui.
*/
Expand Down
1 change: 1 addition & 0 deletions Resources/views/webprofiler.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
<span class="httplug-target">{{ stack.requestTarget }}</span>
</div>
<div>
<span class="label httplug-duration">{{ stack.duration|number_format }} ms</span>
{% if stack.responseCode >= 400 and stack.responseCode <= 599 %}
<span class="label status-error">{{ stack.responseCode }}</span>
{% elseif stack.responseCode >= 300 and stack.responseCode <= 399 %}
Expand Down