Make sure $stack is null or Stack. Never boolean. #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we sure we do always have a stack? Can we remove all these checks if $stack === null? |
|
Now, the only case I see to not having the stack is a user which use by himself the ProfilePlugin decorator without the StackPlugin. |
fbourigault
reviewed
May 11, 2017
Collector/ProfilePlugin.php
Outdated
| @@ -58,7 +58,7 @@ public function handleRequest(RequestInterface $request, callable $next, callabl | |||
| { | |||
| $profile = new Profile($this->pluginName, $this->formatter->formatRequest($request)); | |||
|
|
|||
| if ($stack = $this->collector->getCurrentStack()) { | |||
| if (null !== $stack = $this->collector->getCurrentStack()) { | |||
There was a problem hiding this comment.
Maybe this line will be easier to read if the assignation is moved out of the condition.
There was a problem hiding this comment.
You are correct, It is me that really like this syntax
fbourigault
approved these changes
May 11, 2017
|
Thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a minor change in the return value of
getCurrentStack