Stop mocking immutable/value objects #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This is a cleanup of tests to stop mocking immutable/value objects.
Psr\Http\Message\MessageInterface
andPsr\Http\Message\ResponseInterface
mocks are replaced with
GuzzleHttp\Psr7\Request
andGuzzleHttp\Psr7\Response
respectively.Http\Promise\Promise
mocks are replaced either withHttp\Client\Promise\HttpFulfilledPromise
orHttp\Client\Promise\HttpRejectedPromise
depending on the testrequirements.
Why?
This make tests easier to read, thus to maintain, etc... Also this will help me to solve #175 as it will require some profiling rewrite.