Update package files #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - "spec" | ||
| - "tests" | ||
| path: | ||
| - "src" |
There was a problem hiding this comment.
we follow the symfony bundle best practices here, so these paths are different. the code path is ., exclude is Tests. there is no spec folder.
There was a problem hiding this comment.
spec is there so that we can use the same config in all projects (without thinking about being tested with phpunit or phpspec)
Tests folder: you are right
Fix tests path Update style ci
sagikazarmark
force-pushed
the
package_updates
branch
from
38f0609 to
1dc2ac1
Compare
|
thanks. did not see any scrutinizer output, though. did you activate it? |
|
Just did |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.