-
Notifications
You must be signed in to change notification settings - Fork 50
building the initial bundle #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
## Usage | ||
|
||
TODO: move this to php-http-documentation? or keep it here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagikazarmark wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I tend to follow the following practice: usage section contains a small description about the package, the documentation section contains a link to the relevant documentation. Like here
@@ -0,0 +1,82 @@ | |||
<?php | |||
|
|||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File headers like this should be removed. (At least I started to remove them from all files, because it does not contain any relevant information IMHO). Only author docblocks should be preserved on classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Added a "few" comments, mainly about standards. |
thanks. i will clean that up, but won't get to it before my holidays.
will do in 2 weeks.
|
No problem. I will try to prepare the terminology PR until then so you can also review it before merging. (BTW, if you can quickly review the exception branch before going on holiday, I would be very thankful). Enjoy your holiday. 😎 |
fix #1
feedback highly welcome @sagikazarmark @egeloen
my idea is to get this running when i return from holidays in 2 weeks and then contribute the bundle to the php-http organization. then we can work on porting more features from ivory into the new structure.