Skip to content

Move the exception symbol one step up in the stack #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 18, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
Documentation php-http/documentation#118
License MIT

While making screenshots for the documentation I noticed that the exception symbol was misplaced. Consider the screenshot below.

When an exception is thrown at the error plugin we should have the big red X next to it. Before this PR the symbol appeared first at the content_length plugin.

error-plugin-failure

@sagikazarmark sagikazarmark merged commit c516a4e into php-http:master Jul 18, 2016
@Nyholm
Copy link
Member Author

Nyholm commented Jul 18, 2016

Thank you for merging

@Nyholm Nyholm deleted the dev-profiler-exception branch July 18, 2016 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants