[RFC] Deprecate PluginClient debug_plugins option

[fbourigault]

I don't know the whole history of debug_plugins option (which was introduced in #22), but since this option is no longer used by HTTPlugBundle (php-http/HttplugBundle#128), it could be deprecated and then removed in the next major version.

This will keep the PluginClient more simple.

[Nyholm]

Sure. Your ProfilePlugin has the same functionality. Let's deprecate it until someone says something else.

[fbourigault]

I'm not familiar with phpspec and I'm wondering how can I write a spec for the deprecation notice I will add?

[dbu]

wasn't there something about making a legacy annotation to that test? at least i think i have seen that with phpunit tests. maybe @sagikazarmark can help?

[sagikazarmark]

Not sure if we ever wrote tests for deprecation notices. I don't know about such annotation in PHPSpec.

[dbu]

then lets just deprecate i would say ;-)

[fbourigault]

Just for the knowledge, phpspec introduced the TriggerMatcher in it's 3.2 release.

We can't use it requires php 5.6+