Add an option to only throw exception on 5XX error codes

[joelwurtz]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Related tickets	#77
Documentation	php-http/documentation#235
License	MIT

cf #77

[Nyholm]

I like this feature. Do you think it is a good idea (or overkill) to let the user provide a regex to decide when to throw an exception?

[joelwurtz]

I like this feature. Do you think it is a good idea (or overkill) to let the user provide a regex to decide when to throw an exception?

I think it's overkill, someone can still do it's own plugin for that, however handling 4XX responses is common (like you want the bad request for handling validations, or 404 so you know that this resource does not exist and can handle it properly, but 5XX responses are never wanted because client don't know how to respond to them)

[sagikazarmark]

Like the idea. Is this PR ready?

[joelwurtz]

For me yes

[sagikazarmark]

Great. Can you write some documentation as well?

[dbu]

looks good to me. can you please add documentation for this? then we can merge it. i will bump the branch alias for #103 . do you have time to wrap this and #101 up in the next days? then we can tag version 1.8.0...

[GrahamCampbell]

1.8.0?

[dbu]

i guess we can still add the .0 when we do the release