-
Notifications
You must be signed in to change notification settings - Fork 53
[2.0] Add PHP-CS-Ffixer #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. the settings are slightly different from php-http/boilerplate#27 - i want to be consistent on all projects. but i think the fix here is to update the rules in boilerplate.
and imho we should delete .styleci.yml and disable the hook after this is merged. |
StyleCI config removed. Let me know if I have to do anything else, or if we should add other CS rules. I don't think I can add PrettyCI though. Should I add the CS check in Travis in the meantime? |
no, if you have run the php-cs-fixer on the cli that is good enough. i will merge this and enable pretty-ci. |
|
disabled styleci and enabled prettyci |
What's in this PR?
As suggested in #117 (comment), we can add PHP-CS-Fixer for better DX an stricter CS.
I'm also migrating to Travis CI jobs structure, to allow better flow in the CS (and CS/AST checks too if needed).
Example Usage
To Do