Remove php-cs-fixer from dependencies #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
we went back and forth on this i think. the problem is that cs fixer as well as phpunit sometimes introduce changes that make tests fail when you don't use the right version of the tool. as we use pretty-ci which uses its own version anyways, i am ok with this, however. |
|
Yeah, I understand. Currently we have a problem that php-cs-fixer does not support php7.3 so we cannot support php-73. That is all kinds of wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO PHP-cs-fixer is not a dependency. It is a tool like PHPStrom.
One should not require tools in composer.json.