Make sure we can use PSR-18 clients in version 1.x #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
suggested changes
Dec 30, 2018
|
Just throwing a long shot idea here.. on v1 what if there was a PSR18 HTTPlug adapter? I think someone else has also suggested this but I am lost with all these issues.. |
|
That would not help. Because PSR-18 has the exact same signature but with PHP7 return values. That is why all these updates to 2.x are super simple. They are just dropping PHP5 and adding return values all over the place. |
gmponos
approved these changes
Dec 31, 2018
|
Thank you for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our 2.x branch is compatible with PSR-18. The master branch should also be compatible.
Ive ipdated all places where we are consuming a httplug client. They do now support both httplug 1.x and PSR-18.
FYI @gmponos