Skip to content

Drop PHP7.0 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2019
Merged

Drop PHP7.0 #151

merged 3 commits into from
Jan 4, 2019

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jan 4, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Related tickets fixes #148
Documentation
License MIT

"php-http/httplug": "^2.0",
"php-http/message-factory": "^1.0",
"php-http/message": "^1.6",
"symfony/options-resolver": "^2.6 || ^3.0 || ^4.0"
"symfony/options-resolver": " ^3.4.20 || ^4.0.15 || ^4.1.9 || ^4.2.1"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make it easier for the SAT solver.

@Nyholm Nyholm added this to the v2.0.0 milestone Jan 4, 2019
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also add type declaration, but not necessarily in this PR

@dbu dbu merged commit 32644df into php-http:master Jan 4, 2019
@Nyholm Nyholm deleted the patch-php70 branch January 4, 2019 08:52
@Nyholm
Copy link
Member Author

Nyholm commented Jan 4, 2019

I could not find any type declarations that we should change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop PHP 7.0
2 participants