Skip to content

Made exceptions final #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
(These interfaces use the `Interface` suffix to avoid name collisions.)
- Added an interface for HttpClientPool and moved the abstract class to the HttpClientPool sub namespace.
- AddPathPlugin: Do not add the prefix if the URL already has the same prefix.
- All exceptions in `Http\Client\Common\Exception` are final.

### Removed
- Deprecated option `debug_plugins` has been removed from `PluginClient`
Expand Down
2 changes: 1 addition & 1 deletion src/Exception/CircularRedirectionException.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
*
* @author Joel Wurtz <[email protected]>
*/
class CircularRedirectionException extends HttpException
final class CircularRedirectionException extends HttpException
{
}
2 changes: 1 addition & 1 deletion src/Exception/ClientErrorException.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
*
* @author Joel Wurtz <[email protected]>
*/
class ClientErrorException extends HttpException
final class ClientErrorException extends HttpException
{
}
2 changes: 1 addition & 1 deletion src/Exception/HttpClientNotFoundException.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
*
* @author Joel Wurtz <[email protected]>
*/
class HttpClientNotFoundException extends TransferException
final class HttpClientNotFoundException extends TransferException
{
}
2 changes: 1 addition & 1 deletion src/Exception/LoopException.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
*
* @author Joel Wurtz <[email protected]>
*/
class LoopException extends RequestException
final class LoopException extends RequestException
{
}
2 changes: 1 addition & 1 deletion src/Exception/MultipleRedirectionException.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
*
* @author Joel Wurtz <[email protected]>
*/
class MultipleRedirectionException extends HttpException
final class MultipleRedirectionException extends HttpException
{
}
2 changes: 1 addition & 1 deletion src/Exception/ServerErrorException.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
*
* @author Joel Wurtz <[email protected]>
*/
class ServerErrorException extends HttpException
final class ServerErrorException extends HttpException
{
}