add warning in error plugin #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
force-pushed
the
clarify-error-plugin
branch
from
2ab0e73 to
afa7836
Compare
|
What is your opinion about introducing an ErrorClient instead of an ErrorPlugin? That client can extend only HttpClient.. |
|
Sorry forget about it... doesn't make any difference.. Since HttpClient extends ClientInterface... so it must be PSR-18 either way... |
|
yeah, its a violation of the interface however we produce the exception. but in a smallish application that does not have proper domain exceptions, it can be "good enough" and convenient. if you do several web requests and want to abort the whole thing on (server) error, its easier than checking the return status after each request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warn that the error plugin violates PSR-18