Skip to content

Update date in changelog #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Change Log

## 2.0 (unreleased)
## 2.0.0 - 2019-02-03

### Changed
- HttpClientRouter now throws a HttpClientNoMatchException instead of a RequestException if it can not find a client for the request.
Expand All @@ -10,7 +10,7 @@
- Abstract method `HttpClientPool::chooseHttpClient()` has now an explicit return type (`Http\Client\Common\HttpClientPoolItem`)
- Interface method `Plugin::handleRequest(...)` has now an explicit return type (`Http\Promise\Promise`)
- Made classes final that are not intended to be extended.
Added interfaces for BatchClient, HttpClientRouter and HttpMethodsClient.
- Added interfaces for BatchClient, HttpClientRouter and HttpMethodsClient.
(These interfaces use the `Interface` suffix to avoid name collisions.)
- Added an interface for HttpClientPool and moved the abstract class to the HttpClientPool sub namespace.
- AddPathPlugin: Do not add the prefix if the URL already has the same prefix.
Expand Down
2 changes: 1 addition & 1 deletion src/BatchClientInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ interface BatchClientInterface
* You may not assume that the requests are executed in a particular order. If the order matters
* for your application, use sendRequest sequentially.
*
* @param RequestInterface[] The requests to send
* @param RequestInterface[] $requests The requests to send
*
* @return BatchResult Containing one result per request
*
Expand Down
1 change: 1 addition & 0 deletions src/Exception/BatchException.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ final class BatchException extends TransferException
public function __construct(BatchResult $result)
{
$this->result = $result;
parent::__construct();
}

/**
Expand Down
3 changes: 0 additions & 3 deletions src/Plugin/ContentTypePlugin.php
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,6 @@ private function isJson(StreamInterface $stream): bool
return JSON_ERROR_NONE === json_last_error();
}

/**
* @param $stream StreamInterface
*/
private function isXml(StreamInterface $stream): bool
{
if (!function_exists('simplexml_load_string')) {
Expand Down
2 changes: 1 addition & 1 deletion src/PluginClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ final class PluginClient implements HttpClient, HttpAsyncClient
/**
* An HTTP async client.
*
* @var HttpAsyncClient
* @var HttpAsyncClient|HttpClient
*/
private $client;

Expand Down
2 changes: 1 addition & 1 deletion src/PluginClientFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
final class PluginClientFactory
{
/**
* @var callable
* @var callable|null
*/
private static $factory;

Expand Down