Skip to content

fix cs config #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2020
Merged

fix cs config #191

merged 2 commits into from
Jul 1, 2020

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Jul 1, 2020

symfony settings added a new default setting to force exceptions on one line. this breaks ci because we do have longer exceptions.

@gmponos
Copy link
Contributor

gmponos commented Jul 1, 2020

Things like this will come up again anad again.. unlike PSR2 included in this.. symfony is not a standard hence it's constantly changes.. how about requiring the rules one by one..

If you don't have the time right now I can do it later..

@dbu
Copy link
Contributor Author

dbu commented Jul 1, 2020

afaik sometimes changes to cs-fixer itself also lead to suddenly breaking reports, but definitely its more frequent with symfony. and on some things i actually agree, like the ordered imports :-)

i don't have time for it right now, but i would be happy if you want to change it to psr 2 plus as a starting point the rules that symfony currently has. we should do it for all our repos here though, to be consistent... but afaik, it should be possible to really just copy the cs config to all repos. then there might be breaks revealed, so after updating the config it makes sense to run php-cs-fixer on them again.

@dbu dbu merged commit d5ec7d7 into master Jul 1, 2020
@dbu dbu deleted the styleci branch July 1, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants