Skip to content

Test on PHP 7.1 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2016
Merged

Test on PHP 7.1 #36

merged 2 commits into from
Aug 1, 2016

Conversation

GrahamCampbell
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

Adds PHP 7.1 to the travis test matrix.

Why?

PHP 7.1 is coming later this year, and it would be good to verify compatibility.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

To Do

  • If the PR is not complete but you want to discuss the approach, list what remains to be done here

@sagikazarmark
Copy link
Member

Can you please open a PR in our boilerplate repo too? Thanks

@GrahamCampbell
Copy link
Contributor Author

Yeh. :)

@sagikazarmark
Copy link
Member

Can you please change the before_install line to - if [[ $COVERAGE != true ]]; then phpenv config-rm xdebug.ini || true; fi to see if it fixes the build?

@sagikazarmark
Copy link
Member

Great, thanks. 👍
Can you please apply this fix to the other PRs too?

@sagikazarmark sagikazarmark merged commit d855a91 into php-http:master Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants