Revert "Removed the HTTPClientPool feature" #49
Conversation
|
How does this feature look? Are we ready to merge it back to master and release a stable version? |
|
This is in the queue for a long time now. Can we wrap it up in the near future or we put it on a nice to have list? Currently I added it to the 1.5.0 milestone which has no ETA yet. |
|
Ping. I really want this in master. |
|
Ping @joelwurtz. |
src/HttpClientPoolItem.php
Outdated
| * | ||
| * @return bool | ||
| */ | ||
| public function isDisabled() |
There was a problem hiding this comment.
Should this be final ? (and tagged with @internal)
src/HttpClientPoolItem.php
Outdated
| * | ||
| * @return int | ||
| */ | ||
| public function getSendingRequestCount() |
There was a problem hiding this comment.
Should this be final ? (and tagged with @internal)
|
I ask two questions here, a part from that i'm happy on how it's done. So if you have input on this 👍 |
Nyholm
force-pushed
the
revert-47-no-pool
branch
from
649a88b to
f75916f
Compare
| @@ -69,25 +69,4 @@ public function it_reenable_client(HttpClient $client, RequestInterface $request | |||
| $this->shouldThrow('Http\Client\Exception\HttpException')->duringSendRequest($request); | |||
| $this->shouldThrow('Http\Client\Exception\HttpException')->duringSendRequest($request); | |||
| } | |||
|
|
|||
| public function it_uses_the_lowest_request_client(HttpClientPoolItem $client1, HttpClientPoolItem $client2, RequestInterface $request, ResponseInterface $response) | |||
There was a problem hiding this comment.
Are we okey to remove this? We cannot use $client1->getSendingRequestCount() or $client1->isDisabled() because those methods are final
There was a problem hiding this comment.
:/ Just using @internal should be enough then
Nyholm
force-pushed
the
revert-47-no-pool
branch
from
5e0cb12 to
e7d14e4
Compare
Reverts #47