Supports more cookie date formats in the Cookie Plugin #76
Conversation
aaa2000
changed the title
aaa2000
changed the title
There was a problem hiding this comment.
there are some open issues in message that hopefully can get cleaned up soonish. if we forget, please remind in a week or so and we can just do a release there as the issues are not regressions over 1.5 but just stuff that would be cool to be fixed, so technically we can do the 1.6 release with the current state.
composer.json
Outdated
| @@ -14,7 +14,7 @@ | |||
| "php": ">=5.4", | |||
| "php-http/httplug": "^1.1", | |||
| "php-http/message-factory": "^1.0", | |||
| "php-http/message": "^1.2", | |||
| "php-http/message": "^1.6@dev", | |||
There was a problem hiding this comment.
You should remove "@dev"
Possible add "minimun-stabillity:dev" and "prefer-dist "
There was a problem hiding this comment.
see the TODO list @aaa2000 added. i think this is correct to show that the PR will merge once 1.6 is released. its just that we should not merge until 1.6 is released and then we can change this line to remove @dev before merging.
changing global minimum stability will not change anything for users of this lib, but would potentially have effects on how we install other dependencies.
There was a problem hiding this comment.
I missed that. I think we could release 1.6 of message now.. I will prepare.
|
Could this be released ? :) |
aaa2000
force-pushed
the
cookie-date
branch
from
270699f to
01df19f
Compare
aaa2000
changed the title
|
Rebased and fixed the composer constraint to a stable constraint for the package PR is now mergeable Do I need to correct StyleCI analysis ? (I have not modified |
|
I think you are fine. I will review this PR later this week. Thank you. |
i let styleci fix those in master. if you can rebase again, the style check should become green. |
aaa2000
force-pushed
the
cookie-date
branch
from
01df19f to
d58085d
Compare
|
Friendly ping |
|
Thanks for the PR, and sorry for the wait |
|
Thanks to you and your wonderful library |
What's in this PR?
Supports more cookie date formats in the Cookie Plugin
Checklist
To Do