Improved performance of QueryDefaultsPlugin

[vudaltsov]

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets	#67
Documentation
License	MIT

[dbu]

indeed, that looks like it should be faster.

just to be sure: could this have any kind of side effect? i guess parameter order is preserved (it should not matter, but who knows)? and the behaviour when a parameter name is repeated would also stay the same?

[vudaltsov]

@dbu , yes.

$requestQuery += $defaultQuery will only add elements from default query not existing in request query (including the ones with numeric indexes) according to http://php.net/manual/en/language.operators.array.php, which is exactly the same as iterating over default query and adding to request query with !isset check.

The order will be preserved. The new array will contain elements from $requestQuery in their current order with added nonexisting elements from $defaultQuery in their original order. Same as it was before.

[vudaltsov]

Could this be merged? Or can I help somehow? Maybe add more tests?

[Nyholm]

Im not sure about this. A side effect (that I think I see):

$defaults = ['foo'=>'bar'];
$query = ['foo' => 'newValue'];

// Running the plugin

$output = 'foo=bar&foo=newValue';

Right?

[vudaltsov]

No, the output will be $output = 'foo=newValue'. We parse the given query and merge default values into it (with existing values ignored). And then encode the clean query array and pass it to request.

My solution should have no side effects.

[Nyholm]

okey. Maybe I misread the code. Is there a test that cover this case?

[vudaltsov]

Sure! I hope I have time this weekend to commit such a test.

[vudaltsov]

done

[vudaltsov]

@Nyholm , let's merge it?

[joelwurtz]

Thanks for this @vudaltsov and sorry for the wait, yes let's merge this