Skip to content

Make sure discovery can find the curl client #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2016
Merged

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Mar 6, 2016

No description provided.

@hpatoio
Copy link

hpatoio commented Mar 7, 2016

Why is this commit on puli branch and not on master ?

@sagikazarmark
Copy link
Member

Because the PR is not yet merged.

@hpatoio
Copy link

hpatoio commented Mar 7, 2016

Let's reword my question. Why is puli branch not merged in master ? It seems to me that the commit is correct but maybe I miss something.

I set "php-http/curl-client": "puli-dev@dev" in my composer.json so I'm ok now.

Thanks

@Nyholm
Copy link
Member Author

Nyholm commented Mar 7, 2016

Thank you for testing and reviewing this PR.

sagikazarmark added a commit that referenced this pull request Mar 7, 2016
Make sure discovery can find the curl client
@sagikazarmark sagikazarmark merged commit 2fdfa22 into master Mar 7, 2016
@sagikazarmark sagikazarmark deleted the puli branch March 7, 2016 22:35
@Nyholm
Copy link
Member Author

Nyholm commented Mar 7, 2016

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants