Remove Puli CLI dependency

[mishal]

Please remove dependency on puli. We do not use it, nor symfony stuff. The dependency is too much for our project. I like the discovery for the adapters, but...

Reverting php-http/discovery back to 0.5 saves a lot of deps!

- Removing padraic/phar-updater (dev-master)
- Removing symfony/finder (2.8.x-dev)
- Removing padraic/humbug_get_contents (dev-master)
- Removing webmozart/console (dev-master)
- Removing symfony/console (2.8.x-dev)
- Removing symfony/polyfill-mbstring (dev-master)
- Removing symfony/process (2.8.x-dev)
- Removing psr/log (dev-master)
- Removing ramsey/uuid (2.8.x-dev)
- Removing symfony/event-dispatcher (2.8.x-dev)
- Removing symfony/filesystem (2.8.x-dev)
- Removing webmozart/expression (dev-master)
- Removing webmozart/key-value-store (dev-master)
- Removing webmozart/json (dev-master)
- Removing seld/jsonlint (1.4.0)
- Removing justinrainbow/json-schema (1.5.0)
- Removing webmozart/glob (dev-master)
- Removing webmozart/path-util (dev-master)
- Removing webmozart/assert (dev-master)

[dbu]

discovery does not work without puli anymore. using it allowed us to remove most of our code that rebuilt what puli is doing.

looking at that list, i feel we should be conservative with any other things requiring discovery, however.

[sagikazarmark]

It not just allowed to remove most of our code, but puli is much more generic for the long-term as well. It allows us (and everyone) to improve package integration in ANY framework.

Of course it comes with a price: dependencies to be installed in every project, where the discovery is used.

[mishal]

I checked the ticket #28 but the depencency on puli is not acceptable for our project/s. To install those all packages just to make http client/message discovery is too much.

We decided to use your php-http packages beause they were simple and lightweight.. I know that only in alpa/beta stage...

Is there any chance to have separate branch without this dependency or does it mean we should create 0.5 compatible branch and use it instead of current code? Would it work in future with php-http/client-implementation?

We do not plan to use puli - we have asset packages managed by composer plugins and rails like asset pipeline.

[dbu]

@mishal you can totally use httplug, message and the adapters without discovery. discovery is just a cheap way of "service discovery" in php. we are currently working on the doc. see for example the upcoming guzzle 6 doc at php-http/documentation#67 - works all fine without discovery.

[Nyholm]

I think the issue occurs when you use a library that depends on php-http/discovery. Say if you use friendsofsymfony/http-cache but inject your own client. You still need to download puli/* but you never use the discovery functionality.

[mishal]

Ok, thanks for explanation..

[webmozart]

The main problem here is not Puli, but the dependency on puli/cli. When that dependency is removed, a lot of the other transitive dependencies are gone as well.

[sagikazarmark]

Which gets us back to the beginning.

I have a really mad idea: In/Before Pul Composer plugin we should check if puli CLI is available. If not, download it to vendor/bin? This way we don't explicitly need puli/cli as dependency.

The other possibility is to bundle a puli.phar with the dependency package.

@mishal as @dbu said discovery actually provides service definitions in a highly opinionated way. Although it turned out that the massive dependency issue is caused by including the CLI, puli will still be a dependency nevertheless having cli as a dependency or not, but in the latter case there should be much lighter (which is our goal, having cli installed is only a temporary solution). Would that be acceptable by you?

[sagikazarmark]

Reopening the issue to solve the actual problem.

[webmozart]

I have a really mad idea: In/Before Pul Composer plugin we should check if puli CLI is available. If not, download it to vendor/bin?

I had the same idea five minutes ago. Instead of vendor/bin, I'd download it to the project root though - just like composer.phar by default. Also, we should ask the user before we download.

[mishal]

It looks like that puli/repository-manager has still more then a few dependencies... :(

I need to check it a bit closer.

[webmozart]

@mishal That's a dependency of puli/cli and not needed if the CLI is not installed.