Skip to content

Allow HTTPlug 2 (and hence PSR-18) #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2018
Merged

Allow HTTPlug 2 (and hence PSR-18) #115

merged 4 commits into from
Oct 31, 2018

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Oct 31, 2018

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documentation not yet
License MIT

What's in this PR?

This PR allows HTTPlug 2, and hence PSR-18. This is WIP to start a build and see if there is some compat issue to be resolved.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

To Do

  • Check the build
  • Check if any doc PR is needed
  • Check if any compat fix is needed

@Jean85 Jean85 changed the title [WIP] Allow HTTPlug 2 (and hence PSR-18) Allow HTTPlug 2 (and hence PSR-18) Oct 31, 2018
@Jean85
Copy link
Contributor Author

Jean85 commented Oct 31, 2018

Ok PR is complete! I'm not sure if a doc PR is needed though...

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see anything on http://docs.php-http.org/en/latest/discovery.html mentioning clients we return. and as httplug 1&2 are compatible from a consumer point of view, i think we need not do anything more really, lets merge.

@dbu dbu merged commit 7e9a472 into php-http:master Oct 31, 2018
@dbu
Copy link
Contributor

dbu commented Oct 31, 2018

we do not need a new release of discovery, right?

@Jean85
Copy link
Contributor Author

Jean85 commented Oct 31, 2018

Since this is a change in the composer.json to allow HTTPlug 2, yes @dbu, we need a new (minor?) release. That's the main reason that pushed me toward this PR 😄

@dbu
Copy link
Contributor

dbu commented Oct 31, 2018

the change is only in require-dev though, so its only relevant for the build of this repository, not for any consumers of discovery.

@Jean85 Jean85 deleted the patch-1 branch October 31, 2018 11:01
@Jean85
Copy link
Contributor Author

Jean85 commented Oct 31, 2018

Oh you're right, I didn't change anything outside of the test build! Good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants