-
Notifications
You must be signed in to change notification settings - Fork 46
Allow HTTPlug 2 (and hence PSR-18) #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ok PR is complete! I'm not sure if a doc PR is needed though... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't see anything on http://docs.php-http.org/en/latest/discovery.html mentioning clients we return. and as httplug 1&2 are compatible from a consumer point of view, i think we need not do anything more really, lets merge.
we do not need a new release of discovery, right? |
Since this is a change in the |
the change is only in require-dev though, so its only relevant for the build of this repository, not for any consumers of discovery. |
Oh you're right, I didn't change anything outside of the test build! Good! 👍 |
What's in this PR?
This PR allows HTTPlug 2, and hence PSR-18. This is WIP to start a build and see if there is some compat issue to be resolved.
Checklist
To Do