-
Notifications
You must be signed in to change notification settings - Fork 56
Added docker image to easier build documentation #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RUN pip install alabaster | ||
RUN pip install sphinx_bootstrap_theme | ||
|
||
CMD ["/bin/bash"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline
Maybe we could add a docker-compose file too. |
it works for me but no objections having a docker image. as nobody needs
to install the documentation in a project, we can put as many useful
things into this repo as we want :-)
|
Great idea, however i would prefer to have a smaller image, will do a PR latter (using alpine) |
Although IMO it doesn't matter for development, 💯 👍 for alpine |
I would say let's merge it when the comments are addressed. @joelwurtz can PR anytime he wants. |
https://gist.github.com/joelwurtz/92525e6a37b670b05b3489b19c2548c7 Size of 99mb (not sure if it's smaller then) |
Please, Im quite new to docker. I see that all of you got loads more experience with it. |
Could this be merged? |
Lemme do some improvements first. |
I cant install Sphinx on my OSX. I use the docker image. It would make it easier for others to get started if we included this.
What do you think?