Skip to content

Added docker image to easier build documentation #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 16, 2016

I cant install Sphinx on my OSX. I use the docker image. It would make it easier for others to get started if we included this.

What do you think?

RUN pip install alabaster
RUN pip install sphinx_bootstrap_theme

CMD ["/bin/bash"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

@sagikazarmark
Copy link
Member

Maybe we could add a docker-compose file too.

@dbu
Copy link
Contributor

dbu commented Jul 18, 2016 via email

@joelwurtz
Copy link
Member

Great idea, however i would prefer to have a smaller image, will do a PR latter (using alpine)

@sagikazarmark
Copy link
Member

Although IMO it doesn't matter for development, 💯 👍 for alpine

@sagikazarmark
Copy link
Member

I would say let's merge it when the comments are addressed. @joelwurtz can PR anytime he wants.

@joelwurtz
Copy link
Member

https://gist.github.com/joelwurtz/92525e6a37b670b05b3489b19c2548c7

Size of 99mb (not sure if it's smaller then)

@Nyholm
Copy link
Member Author

Nyholm commented Jul 18, 2016

I would say let's merge it when the comments are addressed. @joelwurtz can PR anytime he wants.

Please, Im quite new to docker. I see that all of you got loads more experience with it.

@Nyholm
Copy link
Member Author

Nyholm commented Jul 27, 2016

Could this be merged?

@sagikazarmark
Copy link
Member

Lemme do some improvements first.

@sagikazarmark sagikazarmark mentioned this pull request Sep 6, 2016
@sagikazarmark sagikazarmark self-assigned this Sep 6, 2016
@Nyholm Nyholm deleted the docker branch September 6, 2016 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants