Multipart stream docs #120
Conversation
| Multipart Stream Builder | ||
| ======================== | ||
|
|
||
| A multipart stream is a special kind of stream that could be used when transferring files over HTTP. There is currently no PSR-7 support for multipart streams as they are considered to be normal streams with a special content. A multipart stream HTTP request may look like this: |
There was a problem hiding this comment.
s/that could be used when transferring files over HTTP/that is used to transfer files over HTTP/
| ------------------------------83ff53821b7c | ||
| Content-Disposition: form-data; name="foo" | ||
|
|
||
| bar |
There was a problem hiding this comment.
can we make this example match exactly with the example below? notably show where the text/plain content type of baz shows up?
|
looks good! reading the doc, i started to wonder why we do not have a MultipartRequestFactory instead... it would be the same, but already pack the stream into a request and add the right content type header. that would get us rid of the boundary dilemma... you could still change headers on the request you got. is there anything i might want to do with the content of a request once i have the multipart stream? sorry to only come up with that now, only realized it when looking at the code example you provide... |
|
Thank you.
These are old code examples, I've showed them before. Anyhow. I do not think a MultipartRequestFactory comply with the single responsibility principle. What if you want to create a ServerRequest or a UpladedFile request with a mutlipart stream? |
| ?PNG | ||
| ??? | ||
| IHDR??? ??? ?????? ???? IDATxc???51?)?:??????IEND?B`? |
There was a problem hiding this comment.
are the question marks intentional ? i think it was something else before. but binary data in the doc file could be a problem when other contributors edit it to update doc. so maybe thats the right thing.
There was a problem hiding this comment.
The question mars are HDR��������������� �����IDATx�c���� which does not make any sense either.. I just represent binary data..
|
These are old code examples, I've showed them before.
sorry, did not want to blame you for missing that. or maybe we even
discussed it before already and i forgot.
anyways, lets keep it as is. the doc looks good to me, only question is
about how we represent the binary data.
|
No description provided.